-
-
Notifications
You must be signed in to change notification settings - Fork 18
replace usage of options with cli #95
base: master
Are you sure you want to change the base?
Conversation
there is some flakyness in how errors are printed to stderr, gonna investigate how to fix this. |
@mfelsche should this be "do not merge for now"? |
This is good to go from my side. Fixed the test issue. Depends on if you want to have the renaming get merged first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell, this looks good. One question regarding a log message.
(
I've built this locally and took it for a spin. One change in behaviour I've noticed is when using
with this branch, it fails,
but passes when using
Now, I'm not saying that this is incorrect -- my expectations aren't violated, putting |
This change was actually not intended, but it makes total sense to me. Previously it was interpreting a simple call of I just think, I need to update the documentation in that respect. And check if |
@jemc and @SeanTAllen do you have an opinion on the change introduced with this PR? Namely, that now instead of:
one has to (and should, even without any flags) write:
Otherwise the While this seems like an accident, i think it is changing the stable cli for good. |
I'm okay with that change, although it does break all of my |
I think it would make sense, to include that change in one go, shortly before we transition the name to |
Discussed at Sync. We will merge this once we renamed to |
and do the necessary refactoring
Well, consistent-ish. I'm still working on consistent
Makefile
Outdated
PONYC = ponyc | ||
else | ||
PONYC = ponyc --debug | ||
PONYC ?= ponyc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm reverting this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I am fine with this. I am just used to use stuff with a version of pony i do not have on the path. And overwriting the used ponyc
from PATH
by setting the environment variable PONYC
, helped me a lot.
Feels weird to approve my own PR. But this is good to go from my side, if it is good for you @SeanTAllen |
and do the necessary refactoring.
Fixes #92